On Tue, Jun 18, 2013 at 6:01 PM, Andres Freund <and...@2ndquadrant.com> wrote: > Hi, > > On 2013-06-18 17:56:34 +0900, Amit Langote wrote: >> Should it be: "return true if attnum is out of range according to the >> tupdesc" instead of "return NULL if attnum is out of range according >> to the tupdesc" at src/backend/access/common/heaptuple.c: 1345 >> >> /* >> * return true if attnum is out of range according to the tupdesc >> */ >> if (attnum > tupleDesc->natts) >> return true; > > Well, true actually tells us that the attribute is null, since that's > the purpose of the function: > > /* > * slot_attisnull > * Detect whether an attribute of the slot is null, without > * actually fetching it. > */ > > I think the comment is more meaningfull before the change since it tells > us how nonexisting columns are interpreted. >
Okay, that makes sense. -- Amit Langote -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
