On Tue, Mar 19, 2013 at 10:37 PM, Daniel Farina <dan...@heroku.com> wrote: > I added programming around various NULL returns reading GUCs in this > revision, v4.
Okay, one more of those fridge-logic bugs. Sorry for the noise. v5.
A missing PG_RETHROW to get the properly finally-esque semantics:
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -642,7 +642,10 @@ dblink_fetch(PG_FUNCTION_ARGS)
}
PG_CATCH();
{
+ /* Pop any set GUCs, if necessary */
restoreLocalGucs(&rgs);
+
+ PG_RE_THROW();
}
PG_END_TRY();
This was easy to add a regression test to exercise, and so I did (not
displayed here).
--
fdr
dblink-guc-sensitive-types-v5.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
