On 03/11/2013 12:30 PM, Fujii Masao wrote:
On Tue, Mar 12, 2013 at 12:43 AM, Andrew Dunstan <and...@dunslane.net> wrote:
On 03/11/2013 10:43 AM, Andrew Dunstan wrote:

On 03/06/2013 10:55 AM, Kevin Grittner wrote:
Bernd Helmle <maili...@oopsware.de> wrote:

Looking into this issue, it seems the version check in getTables() of
pg_dump.c
is wrong. Shouldn't the check be

if (fout->remoteVersion >= 90300)
{

}

since this is where pg_relation_is_scannable() is introduced?
Fixed.

Thanks for the report!




I noticed this morning that I am still getting failures on 9.0, 9.1 and
9.2 which cause my cross-version upgrade testing to fail for git tip. For
all I know this might apply to all back branches, but these are the only
ones tested for upgrade, so that's all I can report on reliably.

I'm chasing it up to find out exactly what's going on, but figured some
extra eyeballs would help.


The problem is that pg_dump is sending an empty query in versions less than
9.3, and choking on that. Suggested fix attached - there's really no reason
to be doing anything re mat views in versions < 9.3.
This is the same problem that I reported in another thread.
http://www.postgresql.org/message-id/CAHGQGwH+4vtyq==l6hrupxtggfqrnlf0mwj75bfisoske28...@mail.gmail.com



Oh, I missed that. Yes, either of these would work.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to