Robert Haas <robertmh...@gmail.com> writes:
> On Sep 15, 2012, at 11:29 AM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> This is only an issue on standby slaves or when doing a PITR recovery, no?
>> As far as I can tell from the discussion, it would *not* affect crash
>> recovery, because we don't do restartpoints during crash recovery.
> No, I think it does affect crash recovery. Whether or not restartspoints
> happen during recovery doesn't matter; what does matter is that after
> recovery there may be shared buffers that are erroneously not marked as
> permanent. Such buffers won't be checkpointed except at shutdown time, which
> is wrong.
Right, but we do a shutdown checkpoint at the end of crash recovery.
I could believe that this case gets missed, but it's not clear from
what's been said --- and if that case *is* broken, there should have
been a whole lot more corruption reports recently than what we've seen.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
