On Sat, Jul 23, 2011 at 9:14 AM, Bruce Momjian <br...@momjian.us> wrote: > Andrew Dunstan wrote: >> > We do use access() in a few other places in our code, but not for >> > directory permission checks. >> > >> > Any ideas on a solution? Will checking stat() work? Do I have to try >> > creating a dummy file and delete it? >> >> That looks like the obvious solution - it's what came to my mind even >> before reading this sentence. > > Well, the easy fix is to see if ALL_DUMP_FILE > ("pg_upgrade_dump_all.sql") exists, and if so remove it, and if not, > create it and remove it. > > Should I fix this in pg_upgrade 9.1 for Windows or just in 9.2? The > check works fine on non-Windows.
Seems worth back-patching to me. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers