On 09.06.2011 17:46, Tom Lane wrote:
"Kevin Grittner"<kevin.gritt...@wicourts.gov> writes:
The other pending patch relates to the false positives serialization
failures and funny-looking pg_lock entries from not ignoring
non-MVCC snapshots in SSI. I don't think Dan had any problem with
the patch I offered, but I wasn't sure what to do about two
functions. He researched that and proposed a way to handle those.
That looked good to me on a first pass except that there was one
line he left at NULL instead of plugging in the snapshot. That looks
like an easily-fixed oversight. It will take me about an hour to
review his changes in detail and re-test everything, although I
don't expect any other issues. It seems odd not to include a change
that was requested by Tom, Robert, and Heikki (and which Dan and I
both put in the hours to have a patch before beta2) in beta2.
Well, Heikki is lead committer for SSI; anything he's comfortable
with pushing in today, he should push. Just keep in mind that it
is too late to get a full buildfarm cycle in before beta2 wraps...
so anything that goes in today had better be low-risk.
I'm not planning to push anything before beta2 anymore. There is a bunch
of SSI related issues pending now, some of which have patches floating
around but I haven't had enough time to review them in depth.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
