On Tue, Jun 7, 2011 at 9:54 PM, Simon Riggs <si...@2ndquadrant.com> wrote: > On Tue, Jun 7, 2011 at 1:24 PM, Robert Haas <robertmh...@gmail.com> wrote: > >> One other thought is that I think that this patch might cause a >> user-visible behavior change. Right now, when you hit the end of >> recovery, you most typically get a message saying - record with zero >> length. Not always, but often. If we adopt this approach, you'll get >> a wider variety of error messages there, depending on exactly how the >> new record fails validation. I dunno if that's important to be worth >> caring about, or not. > > Not. > > We've never said what the message would be, only that it would fail.
BTW, walreceiver doesn't zero the page before writing the WAL. So, if zeroing the page is *really* required for safe recovery, we might need to change walreceiver. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
