-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 According to Linux Standard Base Core Specification 3.1 [1], the exit status should be '3' when the server isn't running.
I've attached a very simple patch that resolves this cosmetic issue, which applies to all branches. My initial search regarding other platforms has turned up nil. It looks like they just check for a zero or non-zero exit status. As for the necessity of the patch: Gentoo Linux uses pg_ctl in all of its initscript actions for PostgreSQL. I'd imagine that Gentoo is not the only distribution that takes advantage of pg_ctl for its initscript actions. Sincerely, Mr. Aaron W. Swenson [1] http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREIAAYFAk3bAO0ACgkQCOhwUhu5AElmsQEAs5rqihVYnglG1l8tiAVE7LZ+ vGq8+YFxRrqlPEt0kQIA/0PIdnf9xlnNewPCZuMRk/uOOeMHBptcDMSTuaWI3QBU =td0Z -----END PGP SIGNATURE-----
diff -cr a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c *** a/src/bin/pg_ctl/pg_ctl.c 2011-04-14 23:15:53.000000000 -0400 --- b/src/bin/pg_ctl/pg_ctl.c 2011-05-22 10:25:34.186930946 -0400 *************** *** 1036,1042 **** } } printf(_("%s: no server running\n"), progname); ! exit(1); } --- 1036,1042 ---- } } printf(_("%s: no server running\n"), progname); ! exit(3); }
pg_ctl-exit-status.patch.sig
Description: PGP signature
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers