On Sun, Nov 21, 2010 at 07:53:57AM -0500, Robert Haas wrote: > On Sat, Nov 20, 2010 at 11:23 PM, Robert Haas <robertmh...@gmail.com> wrote: > > Ah, nuts. I see now there's a v7. Never mind... > > OK. I looked at the right version, now. Hopefully. > > It seems we have no regression tests at all for any of the existing > SET SCHEMA commands. This seems like a good time to correct that > oversight, and also add some for the new commands you're adding here. > (It might be helpful to submit the regression tests for the existing > commands as a separate patch.) Also, you're missing psql tab > completion support, which would be nice to have. > > In CheckSetNamespace() you have the message 'already exists in schema' > there where the existing, similar checks say 'is already in schema', > which is a bit confusing. But that code looks useful, and in fact I > think we should use it for the existing object types also to avoid > code duplication.
Should this really error out? It's just a NOOP, so perhaps a NOTICE would be more appropriate. Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
