On 10/31/2010 11:44 AM, Tom Lane wrote:
=?UTF-8?B?SmFuIFVyYmHFhHNraQ==?=<wulc...@wulczer.org>  writes:
Seems that this circumverts some output conversion error checking, since
adding the attached to the regression suite results in a segfault during
the plperl installcheck.
Reverting 2d01ec0708d571eef926f3f5795aa73759df5d9a fixes it.
Good catch, patch reverted (and regression test added).

Well, I guess that answers the question of why we needed it, which nobody could answer before. I'm not sure I exactly understand what's going on here, though - I guess I need to look at it closer. At least I think we need a code comment on why the trigger flag is needed as part of the hash key.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to