On Tue, Mar 16, 2010 at 12:32 AM, Heikki Linnakangas <heikki.linnakan...@enterprisedb.com> wrote: >> Something like libpq_select() which waits for the socket to become >> ready would be required for walreceiver and dblink. But it's necessary >> for walreceiver on not only win32 but also the other, ... > > Really, why? I thought this is a purely Windows specific problem.
Because, on all the platforms, libpq_receive() needs to call libpq_select(). Or you mean that we should leave the existing libpq_select() as it is, and create new win32 specific function which waits for the socket to become ready, for this issue? > Just replacing PQexec() with PQsendQuery() is pretty straightforward, we > could put that replacement in a file in port/win32. Replacing > PQconnectdb() is more complicated because you need to handle connection > timeout. I suggest that we only add the replacement for PQexec(), and > live with the situation for PQconnectdb(), that covers 99% of the > scenarios anyway. I'll try to replace PQexec() first, and PQconnectdb() second if I have enough time. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
