On Fri, Mar 20, 2009 at 9:57 PM, Andrew Gierth <and...@tao11.riddles.org.uk> wrote: > Note that I'm talking here about the names of the C functions, not > the SQL names. > > The existing hstore has some very dubious choices of function names > (for non-static functions) in the C code; functions like each(), > delete(), fetchval(), defined(), tconvert(), etc. which all look to me > like prime candidates for name collisions and consequent hilarity. > > The patch I'm working on could include fixes for this; but there's an > obvious impact on anyone upgrading from an earlier version... is it > worth it?
Based on that description, +1 from me. That kind of hilarity can be a huge time sink when debugging, and it makes it hard to use grep to find all references to a particular function (or #define, typedef, etc.). ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
