Hi. All suggestion is appropriate and has been checked.
CVS-HEAD was examined by MinGW. $ make check NO_LOCALE=true
... =======================All 118 tests passed. =======================
Then, It continues and a review is desired. Thanks!
Regatrds, Hiroshi Saito----- Original Message ----- From: "Hiroshi Saito" <[EMAIL PROTECTED]>
Hi ITAGAKI-san. Sorry, very late reaction.. I lost time resources in an individual my machine trouble and busyness.:-(Now, I appreciate your exact work. ! Then, I desire the best patch for PostgreSQL. Probably, I think that it is finally helpful in not a problem of only Japan but many countries. Tom-san, and Alvaro-san, Magnus-san understands the essence of this problem. Therefore, the suggestion is expected for me.Anyway, thank you very much.!! Regards, Hiroshi Saito----- Original Message ----- From: "ITAGAKI Takahiro" <[EMAIL PROTECTED]>"Jaime Casanova" <[EMAIL PROTECTED]> wrote:i'm confused, original patch has this signature: + conv_strftime(char *src, size_t len, const char *format, const struct tm *tm) your's has: +strftime_win32(char *dst, size_t dstlen, const char *format, constyou change all src for dst, just a variable name decision but a radical one... why was that (i honestly doesn't understand this patch very well ;)?That's because the first argument is not an input buffer, but an output buffer. MSDN also calls it 'strDest'. http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx Linux manpage calls it 's', but I think it means String, not Src. http://man.cx/strftime If you can review the patch, please use the attached one instead. I modified it in response to the discussion of pg_do_encoding_conversion. BTW, I cannot understand the comment in the function head,+ * result is obtained by locale setup of LC_TIME in the environment + * of windows at present CP_ACP. Therefore, conversion is needed + * for SERVER_ENCODING. SJIS which is not especially made to server + * encoding in Japan returns.but it probably says: ---- strftime in Windows returns in CP_ACP encoding, but it could be different from SERVER_ENCODING. Especially, Windows Japanese edition requires conversions because it uses SJIS as CP_ACP, but we don't support SJIS as a server encoding. ---- I hope you would review my English not only C ;-) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
pg_locale_patch-v5
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
