On Mon, Sep 8, 2008 at 6:59 PM, ITAGAKI Takahiro <[EMAIL PROTECTED]> wrote: > Here is a revised version of the pgbench duration patch. > I merged some comments from Brendan and gnari. >
The changes look good. I tried out the new v3 patch and didn't encounter any problems. One last minor quibble - I think the wording in the documentation is still a little bit awkward: In the first place, <emphasis>never</> believe any test that runs for only a few seconds. Use the <literal>-t</> or <literal>-T</> setting enough to make the run last at least a few minutes, so as to average out noise. This reads better IMHO if you simply omit the word "enough". Cheers, BJ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
