On Wed, Oct 20, 2021 at 4:17 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Oct 20, 2021 at 10:25 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > I have one comment here, basically, you have changed the function name > > to "IsTopTransactionIdLogged", but it still behaves like > > IsTopTransactionIdLogPending. Now with the new name, it should return > > (CurrentTransactionState->topXidLogged) instead of > > (!CurrentTransactionState->topXidLogged). > > > > Valid point but I think the change suggested by you won't be > sufficient. We also need to change all the other checks in that > function to return true which will make it a bit awkward. So instead, > we can change the function name to IsTopTransactionIdLogPending(). > Does that make sense?
Yeah, that makes sense. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
