On Wed, Sep 22, 2021 at 2:17 AM Jeremy Schneider <schnj...@amazon.com> wrote: > > On 9/20/21 22:14, Amit Kapila wrote: > > On Fri, Sep 17, 2021 at 10:53 AM Amit Kapila <amit.kapil...@gmail.com> > > wrote: > >> > >> I don't think it is a bad idea to print additional information as you > >> are suggesting but why only for this error? It could be useful to > >> investigate any other error we get during decoding. I think normally > >> we add such additional information via error_context. We have recently > >> added/enhanced it for apply-workers, see commit [1]. > >> > >> I think here we should just print the relation name in the error > >> message you pointed out and then work on adding additional information > >> via error context as a separate patch. What do you think? > > > > Attached please find the patch which just modifies the current error > > message as proposed by you. I am planning to commit it in a day or two > > unless there are comments or any other suggestions. > > Looks good to me. I see that I hadn't used the macro for getting the > relation name, thanks for fixing that! >
Pushed. -- With Regards, Amit Kapila.