On Sun, Sep 05, 2021 at 07:11:10PM -0500, Justin Pryzby wrote: > I revised the patch based on these comments. I think my ternary patch already > excluded the cases that test something other than a boolean.
In 0002, everything is a boolean expression except for SpGistPageStoresNulls() and GistPageIsLeaf(). So that's a good cleanup overall. - pathnode->parallel_aware = parallel_workers > 0 ? true : false; + pathnode->parallel_aware = parallel_workers > 0; I also prefer that we keep the parenthesis for such things. That's more readable and easier to reason about. -- Michael
signature.asc
Description: PGP signature
