On Tue, Aug 31, 2021 at 9:15 AM vignesh C <vignes...@gmail.com> wrote: > > On Mon, Aug 30, 2021 at 12:12 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > Okay, I got it but let's add few comments in the code related to it. > > Also, I noticed that the code in InvalidatePublicationRels() already > > exists in AlterPublicationOptions(). You can try to refactor the > > existing code as a separate initial patch. > > I have made these changes at the v23 patch attached at [1]. >
* +/* + * Invalidate the relations. + */ +static inline void +InvalidatePublicationRels(List *relids) I don't see the need to make this an inline function. * On similar lines, the code in function GetPubPartitionOptionRelations seems to be extracted from existing function GetPublicationRelations(). Can't we move it into the 0001 patch? -- With Regards, Amit Kapila.
