On Wed, Aug 18, 2021 2:41 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Wed, Aug 18, 2021 at 3:15 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Wed, Aug 18, 2021 at 10:00 AM Masahiko Sawada <sawada.m...@gmail.com> > > wrote: > > > > > > In addition of a code readability, there is a description in the doc > > > that mentions "Stream End" but we describe "Stream Stop" in the > > > later description, which seems a bug in the doc to me: > > > > > > > Doc changes looks good to me. But, I have question for code change: > > > > --- a/src/include/replication/logicalproto.h > > +++ b/src/include/replication/logicalproto.h > > @@ -65,7 +65,7 @@ typedef enum LogicalRepMsgType > > LOGICAL_REP_MSG_COMMIT_PREPARED = 'K', > > LOGICAL_REP_MSG_ROLLBACK_PREPARED = 'r', > > LOGICAL_REP_MSG_STREAM_START = 'S', > > - LOGICAL_REP_MSG_STREAM_END = 'E', > > + LOGICAL_REP_MSG_STREAM_STOP = 'E', > > LOGICAL_REP_MSG_STREAM_COMMIT = 'c', > > > > As this is changing the enum name and if any extension (logical > > replication extension) has started using it then they would require a > > change. As this is the latest change in PG-14, so it might be okay but > > OTOH, as this is just a code readability change, shall we do it only > > for PG-15? > > I think that the doc changes could be backpatched to PG14 but I think we > should do the code change only for PG15.
+1, and the patch looks good to me. Best regards, Hou zj
