On Thu, Aug 12, 2021 at 3:54 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > I've attached the updated patches. FYI I've included the patch > (v8-0005) that fixes the assertion failure during shared fileset > cleanup to make cfbot tests happy. >
Another comment on the 0001 patch: as there is now a mix of setting "apply_error_callback_arg" members directly and also through inline functions, it might look better to have it done consistently with functions having prototypes something like the following: static inline void set_apply_error_context_rel(LogicalRepRelMapEntry *rel); static inline void reset_apply_error_context_rel(void); static inline void set_apply_error_context_attnum(int remote_attnum); Regards, Greg Nancarrow Fujitsu Australia
