On Fri, Jul 23, 2021 at 7:38 PM Peter Smith <smithpb2...@gmail.com> wrote: > > I have reviewed the v10 patch. > > Apply / build / test was all OK. > > Just one review comment: > > ////////// > > 1. Typo > > @@ -130,6 +132,17 @@ typedef struct RelationSyncEntry > TupleConversionMap *map; > } RelationSyncEntry; > > +/* > + * Maintain a per-transaction level variable to track whether the > + * transaction has sent BEGIN or BEGIN PREPARE. BEGIN or BEGIN PREPARE > + * is only sent when the first change in a transaction is processed. > + * This make it possible to skip transactions that are empty. > + */ > > => > > typo: "make it possible" --> "makes it possible" >
fixed. regards, Ajin Cherian Fujitsu Australia
v11-0001-Skip-empty-transactions-for-logical-replication.patch
Description: Binary data
