On Fri, Jul 23, 2021 at 10:13 AM Peter Smith <smithpb2...@gmail.com> wrote: > > I have reviewed the v9 patch and my feedback comments are below: > > ////////// > > 1. Apply v9 gave multiple whitespace warnings
Fixed. > > ------ > > 2. Commit comment - wording > > pgoutput will also skip COMMIT PREPARED and ROLLBACK PREPARED messages > for transactions which were skipped. > > => > > Is that correct? Or did you mean to say: > > AFTER > pgoutput will also skip COMMIT PREPARED and ROLLBACK PREPARED messages > for transactions that are empty. > > ------ Updated. > > 3. src/backend/replication/pgoutput/pgoutput.c - typo > > + /* > + * If the BEGIN PREPARE was not yet sent, then it means there were no > + * relevant changes encountered, so we can skip the COMMIT PREPARED > + * messsage too. > + */ > > Typo: "messsage" --> "message" > > (NOTE this same typo is in 2 places) > Fixed. I have made these changes in v10 of the patch. regards, Ajin Cherian Fujitsu Australia
