On Mon, Jul 19, 2021 at 04:03:33PM +0900, Michael Paquier wrote: > Another advantage of this patch is the handling of ".gz" is reduced to > one code path instead of four. That makes a bit easier the > introduction of new compression methods. > > A second thing that was really confusing is that the name of the WAL > segment generated in this code path completely ignored the type of > compression. This led to one confusing error message if failing to > open a segment for write where we'd mention a .partial file rather > than a .gz.partial file. The versions of zlib I used on Windows > looked buggy so I cannot conclude there, but I am sure that this > should allow bowerbird to handle the test correctly.
After more testing and more review, I have applied and backpatched this stuff. Another thing I did on HEAD was to enable again the ZLIB portion of the pg_receivewal tests on Windows. bowerdird should stay green (I hope), and it is better to have as much more coverage as possible for all that. -- Michael
signature.asc
Description: PGP signature
