Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: > It seems to me that most of the overhead is the function call for > toast_get_compression_id(), so we should get rid of that.
Nice result. I'm willing to live with 1.5% slowdown ... IME that's usually below the noise threshold anyway. > Now, while this patch does seem to work correctly, it raises a number of > weird cpluspluscheck warnings, which I think are attributable to the > new macro definitions. I didn't look into it closely, but I suppose it > should be fixable given sufficient effort: Didn't test, but the first one is certainly fixable by adding a cast, and I guess the others might be as well. regards, tom lane