On Wed, Jun 2, 2021 at 6:11 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Wed, Jun 2, 2021 at 11:43 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Yes, it looks better, but (since the masks are all 1 bit) I was only > > asking why not do like: > > > > if (supported_opts & SUBOPT_CONNECT) > > if (supported_opts & SUBOPT_ENABLED) > > if (supported_opts & SUBOPT_SLOT_NAME) > > if (supported_opts & SUBOPT_COPY_DATA) > > Please review the attached v3 patch further.
Added it to the commitfeset - https://commitfest.postgresql.org/33/3151/ With Regards, Bharath Rupireddy.