On Wed, Jun 2, 2021 at 11:43 AM Peter Smith <smithpb2...@gmail.com> wrote: > Yes, it looks better, but (since the masks are all 1 bit) I was only > asking why not do like: > > if (supported_opts & SUBOPT_CONNECT) > if (supported_opts & SUBOPT_ENABLED) > if (supported_opts & SUBOPT_SLOT_NAME) > if (supported_opts & SUBOPT_COPY_DATA)
Please review the attached v3 patch further. With Regards, Bharath Rupireddy.
v3-0001-Refactor-parse_subscription_options.patch
Description: Binary data