On Thu, May 13, 2021 at 07:39:45PM +0200, Christoph Berg wrote: > Re: Bruce Momjian > > Well, now that we have clear warnings when it is misconfigured, > > especially when querying the pg_stat_statements view, are these > > complaints still valid? Also, how is modifying > > shared_preload_libraries zero-config, but modifying > > shared_preload_libraries and compute_query_id a huge burden? > > It's zero-config in the sense that if you want to have > pg_stat_statements, loading that module via shared_preload_libraries > is just natural. > > Having to set compute_query_id isn't natural. It's a setting with a > completely different name, and the connection of pg_stat_statements to > compute_query_id isn't obvious. > > The reasoning with "we have warnings and stuff" might be ok if > pg_stat_statements were a new thing, but it has worked via > shared_preload_libraries only for the last decade, and requiring > something extra will confuse probably every single user of > pg_stat_statements out there. > > Perhaps worse, note that these warnings will likely first be seen by > the end users of databases, not by the admin performing the initial > setup or upgrade, who will not be able to fix the problem themselves.
Well, but doing this extra configuration, the query id shows up in a lot more places. I can't imagine how this could be done cleanly without requiring extra configuration, unless the query_id computation was cheaper to compute and we could enable it by default. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
