On Tuesday, May 11, 2021 5:44 PM, Dilip Kumar <dilipbal...@gmail.com> wrote:
>But your patch is doing nothing to add the implementation for DELETE..
>USING.  Basically, the tab completion support for DELETE....USING is
>still pending right?

I see, maybe I have a misunderstanding here, I thought tab completion for 
"DELETE....USING" means the code before it as follows.
> >    else if (TailMatches("DELETE", "FROM", MatchAny))
> >            COMPLETE_WITH("USING", "WHERE");

So I just thought the tab completion support for DELETE....USING is not pending 
anymore.
According to your feedback, maybe something beyond my knowledge is need to be 
done for DELETE....USING.

Besides, you are right, the fix in the patch has nothing to do with the comment 
here.
Patch updated to V2 with the sentence moved back. Thanks.

Regards,
Tang

Attachment: V2_0001-TAB-completion-modification-for-INSERT-INTO-and-DELE.patch
Description: V2_0001-TAB-completion-modification-for-INSERT-INTO-and-DELE.patch

Reply via email to