On Mon, May 10, 2021 at 5:57 PM tanghy.f...@fujitsu.com <tanghy.f...@fujitsu.com> wrote: > > On Monday, May 10, 2021 4:15 PM, Julien Rouhaud <rjuju...@gmail.com> wrote > >We should change all to DELETE FROM (apart from \help of course), and same > >for > >INSERT, change to INSERT INTO everywhere it makes sense. > > Thanks for the reply. Your advice sounds reasonable to me. > So I tried to change all "DELETE" to "DELETE FROM" and "INSERT" to "INSERT > INTO" in the attached patch except > the follow cases which I think is in accordance with what PG-Doc said. > CREATE POLICY > CREATE [ OR REPLACE ] RULE > CREATE [ OR REPLACE ] TRIGGER > ALTER DEFAULT PRIVILEGES > > After applying the patch, the tap-tests for psql is passed. > Please be free to tell me anything insufficient you found in my fix. Thanks.
LGTM. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com