On Fri, Apr 30, 2021 at 3:26 PM Mark Dilger
<mark.dil...@enterprisedb.com> wrote:
> It looks mostly good to me.  There is a off-by-one error introduced with:
>
> -   else if (chunkno != (endchunk + 1))
> +   else if (expected_chunk_seq < last_chunk_seq)
>
> I think that needs to be
>
> +  else if (expected_chunk_seq <= last_chunk_seq)
>
> because otherwise it won't complain if the only missing chunk is the very 
> last one.

OK, how about this version?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment: simply-remove-chunkno-concept-v4.patch
Description: Binary data

Reply via email to