Re: pg_amcheck contrib application

[Mark Dilger]

> On Apr 30, 2021, at 11:56 AM, Robert Haas <robertmh...@gmail.com> wrote:
> 
> Can you review this version?

It looks mostly good to me.  There is a off-by-one error introduced with:

-   else if (chunkno != (endchunk + 1))
+   else if (expected_chunk_seq < last_chunk_seq)

I think that needs to be

+  else if (expected_chunk_seq <= last_chunk_seq)

because otherwise it won't complain if the only missing chunk is the very last 
one.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company