On Fri, Apr 09, 2021 at 08:07:10PM -0700, Noah Misch wrote: > "pg_regress --outputdir" is not a great location for a file or directory > created by a user other than the user running pg_regress. If one does "make > check" and then "make installcheck" against a cluster running as a different > user, the rmtree() will fail, assuming typical umask values. An rmtree() at > the end of the tablespace test would mostly prevent that, but that can't help > in the event of a mid-test crash.
Yeah, I really don't think that we need to worry about multi-user scenarios with pg_regress like that though. > I'm not sure we should support installcheck against a server running as a > different user. If we should support it, then I'd probably look at letting > the caller pass in a server-writable directory. That directory would house > the tablespace instead of outputdir doing so. But, then, we would be back to the pre-13 position where we'd need to have something external to pg_regress in charge of cleaning up and creating the tablespace path, no? That's basically what we want to avoid with the Makefile rules. I can get that it could be interesting to be able to pass down a custom path for the test tablespace, but do we really have a need for that? It took some time for the CF bot to run the patch of this thread, but from what I can see the tests are passing on Windows under Cirrus CI: http://commitfest.cputube.org/michael-paquier.html So it looks like this could be a different answer. -- Michael
signature.asc
Description: PGP signature
