On 3/29/21 4:34 AM, Magnus Hagander wrote:
On Mon, Mar 29, 2021 at 7:01 AM Michael Paquier <mich...@paquier.xyz> wrote:
On Sun, Mar 28, 2021 at 09:29:10AM -0400, Andrew Dunstan wrote:
- vital to the backup working, and must be written without modification.
+ vital to the backup working and must be written without
modification, which
+ may include opening the file in binary mode.
+= "on Windows"?
I'd say no, better to just tell people to always open the file in
binary mode. It's not hurtful anywhere, there's really no reason ever
to open it in text mode.
Agreed. New patch attached.
Regards,
--
-David
da...@pgmasters.net
diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml
index c5557d5444..8c9186d277 100644
--- a/doc/src/sgml/backup.sgml
+++ b/doc/src/sgml/backup.sgml
@@ -913,7 +913,8 @@ SELECT * FROM pg_stop_backup(false, true);
<filename>backup_label</filename> in the root directory of the backup. The
third field should be written to a file named
<filename>tablespace_map</filename> unless the field is empty. These
files are
- vital to the backup working, and must be written without modification.
+ vital to the backup working and must be written byte for byte without
+ modification, which may require opening the file in binary mode.
</para>
</listitem>
<listitem>
