On Wed, Mar 24, 2021 at 11:31 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Mar 23, 2021 at 3:31 PM Peter Smith <smithpb2...@gmail.com> wrote: > > > > On Tue, Mar 23, 2021 at 10:44 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > PSA patches to fix those. > > > > > > > Hi Amit. > > > > PSA a patch to allow the ALTER SUBSCRIPTION ... REFRESH PUBLICATION to > > work when two-phase tristate is PENDING. > > > > This is necessary for the pg_dump/pg_restore scenario, or for any > > other use-case where the subscription might > > start off having no tables. > > > > + subrels = GetSubscriptionRelations(MySubscription->oid); > + > + /* > + * If there are no tables then leave the state as PENDING, which > + * allows ALTER SUBSCRIPTION ... REFRESH PUBLICATION to work. > + */ > + become_two_phase_enabled = list_length(subrels) > 0; > > This code is similar at both the places it is used. Isn't it better to > move this inside AllTablesyncsReady and if required then we can change > the name of the function.
I agree. That way is better. PSA a patch which changes the AllTableSyncsReady function to now include the zero tables check. (This patch is to be applied on top of all previous patches) ------ Kind Regards, Peter Smith. Fujitsu Australia.
v66-0005-Change-AllTablesyncsReady-to-return-false-when-0.patch
Description: Binary data
