Hello
On Sunday, March 21, 2021 4:37 PM Amit Kapila <amit.kapil...@gmail.com>
> On Sat, Mar 20, 2021 at 10:09 AM Ajin Cherian <itsa...@gmail.com> wrote:
> >
> > On Sat, Mar 20, 2021 at 1:35 AM Amit Kapila <amit.kapil...@gmail.com>
> wrote:
> >>
> >> On Fri, Mar 19, 2021 at 5:03 AM Ajin Cherian <itsa...@gmail.com> wrote:
> >> >
> >> > Missed the patch - 0001, resending.
> >> >
> >>
> >> I have made miscellaneous changes in the patch which includes
> >> improving comments, error messages, and miscellaneous coding
> >> improvements. The most notable one is that we don't need an
> >> additional parameter in walrcv_startstreaming, if the two_phase
> >> option is set properly. My changes are in
> >> v63-0002-Misc-changes-by-Amit, if you are fine with those, then
> >> please merge them in the next version. I have omitted the dev-logs
> >> patch but feel free to submit it. I have one
> >> question:
> >>
> >
> > I am fine with these changes. I see that Peter has already merged in these
> changes.
> >
>
> I have further updated the patch to implement unique GID on the
> subscriber-side as discussed in the nearby thread [1]. That requires some
> changes in the test.
Thank you for your update. v65 didn't make any failure during make check-world.
I've written additional tests for alter subscription using refresh
for enabled subscription and two_phase = on.
I wrote those as TAP tests because refresh requires enabled subscription
and to get a subscription enabled, we need to set connect true as well.
TAP tests are for having connection between sub and pub,
and tests in subscription.sql are aligned with connect=false.
Just in case, I ran 020_twophase.pl with this patch 100 times, based on v65 as
well
and didn't cause any failure. Please have a look at the attached patch.
Best Regards,
Takamichi Osumi
0001-additional-tests-for-ALTER-SUBSCRIPTION.patch
Description: 0001-additional-tests-for-ALTER-SUBSCRIPTION.patch
