On 3/24/21 8:29 AM, Alvaro Herrera wrote: > On 2021-Mar-24, Dagfinn Ilmari Mannsåker wrote: > >> I think it would be even neater having a method that returns the desired >> environment and then have the other methods do: >> >> local %ENV = $self->_get_install_env(); > Hmm, is it possible to integrate PGHOST and PGPORT handling into this > too? Seems like it is, so the name of the routine should be something > more general (and also it should not have the quick "return unless > $inst"). >
If we're going to do that we probably shouldn't special case any particular settings, but simply take any extra arguments as extra env settings. And if any setting has undef (e.g. PGAPPNAME) we should unset it. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
