On Thu, Jan 28, 2021 at 10:19:57AM -0500, Andrew Dunstan wrote:
> +BEGIN
> +{
> +
> + # putting this in a BEGIN block means it's run and checked by perl -c
> +
> +
> + # everything other than info and get_new_node that we need to override.
> + # they are all instance methods, so we can use the same template for all.
> + my @instance_overrides = qw(init backup start kill9 stop reload restart
> + promote logrotate safe_psql psql background_psql
> + interactive_psql poll_query_until command_ok
> + command_fails command_like command_checks_all
> + issues_sql_like run_log pg_recvlogical_upto
> + );No actual objections here, but it would be easy to miss the addition of a new routine. Would an exclusion filter be more adapted, aka override everything except get_new_node() and info()? -- Michael
signature.asc
Description: PGP signature
