On Sat, Mar 13, 2021 at 1:55 AM Mark Dilger <mark.dil...@enterprisedb.com> wrote: > I thought about that, but I'm not sure that it proves much more than just > using zero. The test doesn't really do much of interest with this value, and > it doesn't seem worth complicating the test. The idea originally was that > perl's "q" pack code would make reading/writing a number such as 12345678 > easy, but since it's not easy, this is easy.
I think it would be good to use a non-zero value here. We're doing a lot of poking into raw bytes here, and if something goes wrong, a zero value is more likely to look like something normal than whatever else. I suggest picking a value where all 8 bytes are the same, but not zero, and ideally chosen so that they don't look much like any of the surrounding bytes. -- Robert Haas EDB: http://www.enterprisedb.com
