On Mon, Feb 15, 2021 at 1:58 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > On Sun, Feb 14, 2021 at 12:49:40PM -0600, Justin Pryzby wrote: > > On Wed, Feb 10, 2021 at 04:56:17PM -0500, Robert Haas wrote: > > > Small delta patch with a few other suggested changes attached. > > > > Robert's fixup patch caused the CI to fail, since it 1) was called *.patch; > > and, 2) didn't include the previous patches. > > > > This includes a couple proposals of mine as separate patches. > > CIs failed on BSD and linux due to a test in contrib/, but others passed. > https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.127551 > https://cirrus-ci.com/task/6087701947482112 > https://cirrus-ci.com/task/6650651900903424 > https://cirrus-ci.com/task/5524751994060800 > > Resending with fixes to configure.ac and missed autoconf run. I think this is > expected to fail on mac, due to missing LZ4. > > BTW, compressamapi.h doesn't need to be included in any of these, at least in > the 0001 patch: > > src/backend/access/common/indextuple.c | 2 +- > src/backend/catalog/heap.c | 2 +- > src/backend/catalog/index.c | 2 +- > src/backend/parser/parse_utilcmd.c | 2 +- > > It's pretty unfriendly that this requires quoting the integer to be > syntactically valid: > > |postgres=# create table j(q text compression pglz with (level 1) ); > |2021-01-30 01:26:33.554 CST [31814] ERROR: syntax error at or near "1" at > character 52 > |2021-01-30 01:26:33.554 CST [31814] STATEMENT: create table j(q text > compression pglz with (level 1) ); > |ERROR: syntax error at or near "1" > |LINE 1: create table j(q text compression pglz with (level 1) );
Thanks for the review and patch for HIDE_COMPRESSAM, I will merge this into the main patch. And work on other comments after fixing the issue related to compressed data in composite types. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
