On Wed, 2021-01-27 at 16:39 +0900, Michael Paquier wrote:
> My apologies for chiming in. I was looking at your patch set here,
> and while reviewing the strong random and cryptohash parts I have
> found a couple of mistakes in the ./configure part. I think that the
> switch from --with-openssl to --with-ssl={openssl} could just be done
> independently as a building piece of the rest, then the first portion
> based on NSS could just add the minimum set in configure.ac.
>
> Please note that the patch set has been using autoconf from Debian, or
> something forked from upstream. There were also missing updates in
> several parts of the code base, and a lack of docs for the new
> switch. I have spent time checking that with --with-openssl to make
> sure that the obsolete grammar is still compatible, --with-ssl=openssl
> and also without it.
>
> Thoughts?
Seems good to me on Ubuntu; builds with both flavors.
From peering at the Windows side:
> --- a/src/tools/msvc/config_default.pl
> +++ b/src/tools/msvc/config_default.pl
> @@ -16,7 +16,7 @@ our $config = {
> tcl => undef, # --with-tcl=<path>
> perl => undef, # --with-perl=<path>
> python => undef, # --with-python=<path>
> - openssl => undef, # --with-openssl=<path>
> + openssl => undef, # --with-ssl=openssl with <path>
> uuid => undef, # --with-uuid=<path>
> xml => undef, # --with-libxml=<path>
> xslt => undef, # --with-libxslt=<path>
So to check understanding: the `openssl` config variable is still alive
for MSVC builds; it just turns that into `--with-ssl=openssl` in the
fake CONFIGURE_ARGS?
<bikeshed color="lightblue">
Since SSL is an obsolete term, and the choice of OpenSSL vs NSS vs
[nothing] affects server operation (such as cryptohash) regardless of
whether or not connection-level TLS is actually used, what would you
all think about naming this option --with-crypto? I.e.
--with-crypto=openssl
--with-crypto=nss
</bikeshed>
--Jacob
