On Thu, Jan 14, 2021 at 9:26 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > * You need to remove pread.o and pwrite.o from the hard-wired > part of the list in src/port/Makefile, else they get built > whether needed or not.
Right, done. > * I don't much like this in fd.h: > > @@ -46,6 +46,7 @@ > #include <dirent.h> > > > +struct iovec; > typedef int File; > > because it makes it look like iovec and File are of similar > status, which they hardly are. Perhaps more like > > #include <dirent.h> > + > +struct iovec; /* avoid including sys/uio.h here */ Done, except I wrote port/pg_iovec.h. > I confirm clean builds on Big Sur and Catalina with this. Thanks for checking. I also checked on Windows via CI. Pushed.
