On Wed, Dec 23, 2020 at 07:30:35PM +0300, Alexey Kondratov wrote: > After eyeballing the patch I can add that we should alter this comment: > > int options; /* bitmask of VacuumOption */ > > as you are going to replace VacuumOption with VACOPT_* defs. So this should > say: > > /* bitmask of VACOPT_* */
Check. > > Also I have found naming to be a bit inconsistent: > * we have ReindexOptions, but VacuumParams > * and ReindexOptions->flags, but VacuumParams->options Check. As ReindexOptions and ClusterOptions are the new members of the family here, we could change them to use Params instead with "options" as bits32 internally. > And the last one, you have used bits32 for Cluster/ReindexOptions, but left > VacuumParams->options as int. Maybe we should also change it to bits32 for > consistency? Yeah, that makes sense. I'll send an updated patch based on that. -- Michael
signature.asc
Description: PGP signature
