On Wed, Dec 23, 2020 at 09:14:18PM -0300, Alvaro Herrera wrote: > On 2020-Dec-23, Justin Pryzby wrote: > > > This was getting ugly: > > > > extern void reindex_index(Oid indexId, bool skip_constraint_checks, > > char relpersistence, int options, Oid > > tablespaceOid)Z > > Is this what I suggested?
No ; that was from an earlier revision of the patch adding the tablespace, before Michael suggested a ReindexOptions struct, which subsumes 'options' and 'tablespaceOid'. I see now that 'skip_constraint_checks' is from REINDEX_REL_CHECK_CONSTRAINTS. It seems liek that should be a REINDEXOPT_* flag, rather than REINDEX_REL_*, so doesn't need to be a separate boolean. See also: 2d3320d3d. -- Justin
