On Mon, 7 Dec 2020 at 11:09, Peter Eisentraut <peter.eisentr...@enterprisedb.com> wrote: > > get_constraint_index() does its work by going through pg_depend. It was > added before pg_constraint.conindid was added, and some callers are > still not changed. Are there reasons for that? Probably not. The > attached patch changes get_constraint_index() to an lsyscache-style > lookup instead.
This looks quite reasonable, and it passes "make installcheck-world". Only thing I could think of is that it maybe could use a (small) comment in the message on that/why get_constraint_index is moved to utils/lsyscache from catalog/dependency, as that took me some time to understand.
