On Wed, Dec 2, 2020 at 8:24 PM Peter Smith <smithpb2...@gmail.com> wrote: > > I have rebased the v28 patch set (made necessary due to recent commit [1]) > [1] > https://github.com/postgres/postgres/commit/0926e96c493443644ba8e96b5d96d013a9ffaf64 > > And at the same time I have added patch 0009 to this set - This is for > the new SUBSCRIPTION option "two_phase" (0009 is still WIP but > stable). > > PSA new patch set with version bumped to v29.
Thank you for updating the patch! While looking at the patch set I found that the tests in src/test/subscription don't work with this patch. I got the following error: 2020-12-03 15:18:12.666 JST [44771] tap_sub ERROR: unrecognized pgoutput option: two_phase 2020-12-03 15:18:12.666 JST [44771] tap_sub CONTEXT: slot "tap_sub", output plugin "pgoutput", in the startup callback 2020-12-03 15:18:12.666 JST [44771] tap_sub STATEMENT: START_REPLICATION SLOT "tap_sub" LOGICAL 0/0 (proto_version '2', two_phase 'on', publication_names '"tap_pub","tap_pub_ins_only"') In v29-0009 patch "two_phase" option is added on the subscription side (i.g., libpqwalreceiver) but it seems not on the publisher side (pgoutput). Regards, -- Masahiko Sawada EnterpriseDB: https://www.enterprisedb.com/
