On 21.10.20 23:12, David G. Johnston wrote:
On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker
<ilm...@ilmari.org <mailto:ilm...@ilmari.org>> wrote:
Michael Paquier <mich...@paquier.xyz <mailto:mich...@paquier.xyz>>
writes:
> On Mon, Aug 10, 2020 at 12:52:17PM +0000, Jürgen Purtz wrote:
>> The new status of this patch is: Waiting on Author
>
> This has not been answered yet, so I have marked the patch as
returned
> with feedback.
Updated patch attached, wich reformats the operator lists as requested
by Jürgen,
A couple of things:
One, I would place the equality operator for hash inside a standalone
synopsis just like all of the others.
ok
Two, why is hash special in having its create index command provided
here? (I notice this isn't the fault of this patch but it stands out
when reviewing it)
yes, this looks odd.
I would suggest rewording hash to look more like the others
ok
and add a link to the "CREATE INDEX" command from the chapter preamble.
is the link necessary?
and skips the reindentation as suggested by Tom.
Agreed
David J.
--
J. Purtz
