On Thu, Oct 22, 2020 at 4:04 PM Mark Dilger <mark.dil...@enterprisedb.com> wrote: > I think the compiler warning was about fxid not being set. The callers pass > NULL for status if they don't want status checked, so writing *status > unconditionally would be an error. Also, if the xid being checked is out of > bounds, we can't check the status of the xid in clog.
Sorry, you're (partly) right. The new logic is a lot more clear that we never used that uninitialized. I'll remove the extra semi-colon and commit this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company