> On 3 Sep 2020, at 07:35, Michael Paquier <mich...@paquier.xyz> wrote: > > On Tue, Sep 01, 2020 at 11:53:36AM +0200, Daniel Gustafsson wrote: >> On 14 Aug 2020, at 20:23, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: >> >>> The logic to keep track number of used slots used is baroque, though -- that >>> could use a lot of simplification. >> >> What if slot_init was an integer which increments together with the loop >> variable until max_slots is reached? If so, maybe it should be renamed >> slot_init_count and slotCount renamed slot_stored_count to make the their use >> clearer? > > Good idea, removing slot_init looks like a good thing for readability. > And the same can be done for pg_shdepend.
I think this version is a clear improvement. Nothing more sticks out from a read-through. cheers ./daniel
