On Thu, Jul 2, 2020 at 10:10 PM Pavel Stehule <pavel.steh...@gmail.com> wrote:
> > > čt 2. 7. 2020 v 17:27 odesílatel Daniel Gustafsson <dan...@yesql.se> > napsal: > >> > On 23 Jun 2020, at 11:51, Pavel Stehule <pavel.steh...@gmail.com> >> wrote: >> >> > I changed the name to more accurately "unicode_unescape". Patch is >> assigned >> >> You've made this function return Oid, where it used to be void. Was that >> a >> copy-paste mistake? Else the code needs fixing as it doesn't return an >> Oid. >> >> +Oid >> +check_unicode_value(pg_wchar c) >> +{ >> + if (!is_valid_unicode_codepoint(c)) >> + ereport(ERROR, >> + (errcode(ERRCODE_SYNTAX_ERROR), >> + errmsg("invalid Unicode escape value"))); >> +} >> >> > yes, it is my error > > I am sending fixed patch > > Thank you for check > > Pavel > > cheers ./daniel >> > Hi Pavel, Since the idea originated from unescaping unicode string literals i.e. select unescape('Odpov\u011Bdn\u00E1 osoba'); Shouldn't the built-in function support the above syntax as well? -- Asif Rehman Highgo Software (Canada/China/Pakistan) URL : www.highgo.ca