On 2020-07-08 11:15, Fujii Masao wrote:
On 2020/07/08 11:02, torikoshia wrote:
Hi,
Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
but it seems that should be "XLogSegNo" because this variable is
segment number.
How do you think?
I agree that using XLogRecPtr for slot_keep_segs is incorrect.
But this variable indicates the number of segments rather than
segment no, uint64 seems better. Thought?
That makes sense.
The number of segments and segment number are different.
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
